[PATCH] D107967: [JITLink] Update ELF_x86_64 's edge kind to generic edge kind

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Thanks very much Stephen! Having this uniform architecture support in place for the x86-64 backend is a big step forward for JITLink. E.g. once this lands we can unify `optimizeELF_x86_64_GOTAndStubs` and `optimizeMachO_x86_64_GOTAndStubs` into a pure `optimize_x86_64_GOTAndStubs` function. :)

Could you change GOTDelta64 to Delta64FromGOT. The name is clunkier, but it makes it clear which way the delta goes.

Otherwise this looks good to me -- please land whenever you're ready.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:375-376
                              const object::ELFFile<object::ELF64LE> &Obj)
       : ELFLinkGraphBuilder(Obj, Triple("x86_64-unknown-linux"), FileName,
                             getELFX86RelocationKindName) {}
 };
----------------
`getELFX86RelocationKindName` should be replaced with `x86_64::getEdgeKindName` here, since graph edges will now use the generic kinds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107967/new/

https://reviews.llvm.org/D107967