[PATCH] D108000: [IFS] Fix copy constructor warnings in IFSStub.cpp

Haowei Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 14:46:29 PDT 2021


haowei created this revision.
haowei added reviewers: mcgrathr, lbenes, phosek.
Herald added a subscriber: hiraditya.
haowei requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This change fixes the gcc warning on copy constructor in IFSStub.cpp file.

After this patch, gcc-11 no longer show the warning

  /llvm/lib/InterfaceStub/IFSStub.cpp: In copy constructor ‘llvm::ifs::IFSStubTriple::IFSStubTriple(const llvm::ifs::IFSStubTriple&)’:
  /llvm/lib/InterfaceStub/IFSStub.cpp:32:1: warning: base class ‘struct llvm::ifs::IFSStub’ should be explicitly initialized in the copy constructor [-Wextra]
     32 | IFSStubTriple::IFSStubTriple(IFSStubTriple const &Stub) {
        | ^~~~~~~~~~~~~


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108000

Files:
  llvm/lib/InterfaceStub/IFSStub.cpp


Index: llvm/lib/InterfaceStub/IFSStub.cpp
===================================================================
--- llvm/lib/InterfaceStub/IFSStub.cpp
+++ llvm/lib/InterfaceStub/IFSStub.cpp
@@ -29,7 +29,7 @@
   Symbols = std::move(Stub.Symbols);
 }
 
-IFSStubTriple::IFSStubTriple(IFSStubTriple const &Stub) {
+IFSStubTriple::IFSStubTriple(IFSStubTriple const &Stub) : IFSStub() {
   IfsVersion = Stub.IfsVersion;
   Target = Stub.Target;
   SoName = Stub.SoName;
@@ -37,7 +37,7 @@
   Symbols = Stub.Symbols;
 }
 
-IFSStubTriple::IFSStubTriple(IFSStub const &Stub) {
+IFSStubTriple::IFSStubTriple(IFSStub const &Stub) : IFSStub() {
   IfsVersion = Stub.IfsVersion;
   Target = Stub.Target;
   SoName = Stub.SoName;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108000.366114.patch
Type: text/x-patch
Size: 713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210812/e3e6b2bc/attachment.bin>


More information about the llvm-commits mailing list