[PATCH] D107770: [CallPromotion] Fix byval/inalloca handling

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 14:04:13 PDT 2021


efriedma added a comment.

I'd prefer to prohibit the promotion.

In general, when we see a mismatch in the argument list, we want to be conservative; ABI rules are complicated, so sometimes different frontends will emit different IR signatures for a given function which should be ABI-compatible.  An argument list with byval is effectively a different signature from an argument list without byval.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107770/new/

https://reviews.llvm.org/D107770



More information about the llvm-commits mailing list