[PATCH] D107353: [LoopIdiom] let the pass deal with runtime memset size

[Zheng Qian via Phabricator via llvm-commits]

qianzhen added a comment.

Added some minor NFC comments.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:899
                                            const SCEV *BECount) {
   // We can only handle non-volatile memsets with a constant size.
+  if (MSI->isVolatile())
----------------
"with a constant size" can be removed, since the new code is trying to handle a non-constant size.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:965
+
+    // compare positive direction strideSCEV with MemsizeSizeSCEV
+    IsNegStride = StrideSCEV->isNonConstantNegative();
----------------
"MemsizeSizeSCEV" -> "MemsetSizeSCEV"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107353/new/

https://reviews.llvm.org/D107353