[PATCH] D107940: [WebAssembly] Disable offset folding for function addresses

[Heejin Ahn via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG78e87970af88: [WebAssembly] Disable offset folding for function addresses (authored by aheejin).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107940/new/

https://reviews.llvm.org/D107940

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
  llvm/test/CodeGen/WebAssembly/function-addr-offset.ll


Index: llvm/test/CodeGen/WebAssembly/function-addr-offset.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/WebAssembly/function-addr-offset.ll
@@ -0,0 +1,35 @@
+; RUN: llc < %s -verify-machineinstrs | FileCheck %s
+
+; Wasm does not currently support function addresses with offsets, so we
+; shouldn't try to create a folded SDNode like (function + offset). This is a
+; regression test for the folding bug and this should not crash in MCInstLower.
+
+target triple = "wasm32-unknown-unknown"
+
+; 'hidden' here should be present to reproduce the bug
+declare hidden void @ham(i8*)
+
+define void @bar(i8* %ptr) {
+bb1:
+  br i1 undef, label %bb3, label %bb2
+
+bb2:
+  ; While lowering this switch, isel creates (@ham + 1) expression as a course
+  ; of range optimization for switch, and tries to fold the expression, but
+  ; wasm does not support with function addresses with offsets. This folding
+  ; should be disabled.
+  ; CHECK:      i32.const  ham
+  ; CHECK-NEXT: i32.const  1
+  ; CHECK-NEXT: i32.add
+  switch i32 ptrtoint (void (i8*)* @ham to i32), label %bb4 [
+    i32 -1, label %bb3
+    i32 0, label %bb3
+  ]
+
+bb3:
+  unreachable
+
+bb4:
+  %tmp = load i8, i8* %ptr
+  unreachable
+}
Index: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
+++ llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
@@ -102,6 +102,7 @@
                                       bool *Fast) const override;
   bool isIntDivCheap(EVT VT, AttributeList Attr) const override;
   bool isVectorLoadExtDesirable(SDValue ExtVal) const override;
+  bool isOffsetFoldingLegal(const GlobalAddressSDNode *GA) const override;
   EVT getSetCCResultType(const DataLayout &DL, LLVMContext &Context,
                          EVT VT) const override;
   bool getTgtMemIntrinsic(IntrinsicInfo &Info, const CallInst &I,
Index: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -770,6 +770,13 @@
          (ExtT == MVT::v2i64 && MemT == MVT::v2i32);
 }
 
+bool WebAssemblyTargetLowering::isOffsetFoldingLegal(
+    const GlobalAddressSDNode *GA) const {
+  // Wasm doesn't support function addresses with offsets
+  const GlobalValue *GV = GA->getGlobal();
+  return isa<Function>(GV) ? false : TargetLowering::isOffsetFoldingLegal(GA);
+}
+
 EVT WebAssemblyTargetLowering::getSetCCResultType(const DataLayout &DL,
                                                   LLVMContext &C,
                                                   EVT VT) const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107940.366091.patch
Type: text/x-patch
Size: 2816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210812/305967b2/attachment.bin>