[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

I get that enabling the new SjLj will require enabling the wasm EH feature, but it's not obvious why it should require `--exception-model=wasm` Is it possible to enable the new SJLJ with `exception-model=none` and have it force on `-mattr=+exception-handling` (or failing that, require only `-mattr=+exception-handling` and not both)? I would think e.g. this should eventually be the default for plain C code.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:393
+      TM->Options.ExceptionModel != ExceptionHandling::Wasm)
+    report_fatal_error("-exception-model should be either 'none' of 'wasm'");
+  if (WasmEnableEmException &&
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107685/new/

https://reviews.llvm.org/D107685