[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2229-2230
     return this;
+  if (EnableFSDiscriminator)
+    return cloneWithDiscriminator(D);
   if (Optional<unsigned> Encoded = encodeDiscriminator(D, DF, CI))
----------------
EnableFSDiscriminator has been handled above already?


================
Comment at: llvm/lib/CodeGen/FlowSensitiveSampleProfile.cpp:165
+template <>
+void SampleProfileLoaderBaseImpl<MachineBasicBlock>::buildEdges(FunctionT &F) {
+  for (auto &BI : F) {
----------------
What is its difference with the generic version of SampleProfileLoaderBaseImpl<BT>::buildEdges? They look similar.


================
Comment at: llvm/lib/CodeGen/FlowSensitiveSampleProfile.cpp:276
+  auto ReaderOrErr =
+      sampleprof::SampleProfileReader::create(Filename, Ctx, P, "");
+  if (std::error_code EC = ReaderOrErr.getError()) {
----------------
We may want to set remapping file otherwise remapping cannot be effective enough when FSAFDO is enabled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878