[PATCH] D107967: [JITLink] Update ELF_x86_64 's edge kind to generic edge kind
luxufan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 12 08:32:21 PDT 2021
StephenFan created this revision.
StephenFan added a reviewer: lhames.
Herald added subscribers: pengfei, hiraditya.
StephenFan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This patch uses a switch statement to map the ELF_x86_64's edge kind to generic edge kind, and merge the ELF_x86_64 's applyFixup function to the x86_64 's applyFixup function. Some edge kinds were not have corresponding generic edge kinds, so I added three generic edge kinds asa follows:
1. RequestGOTAndTransformToDelta64, which is similar to RequestGOTAndTransformToDelta32.
2. GOTDelta64. This generic kind is similar to Delta64, except the GOTDelta64 computes the delta relative to GOTSymbol
3. RequestGOTAndTransformToGOTDelta64. This edge kind was used to deal with ELF_x86_64's GOT64 edge kind, it request the fixGOTEdge function to change the target to GOT entry, and set the edge kind to generic edge kind GOTDelta64.
These added generic edge kinds may named haphazardly, or can't express its meaning well.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D107967
Files:
llvm/include/llvm/ExecutionEngine/JITLink/ELF_x86_64.h
llvm/include/llvm/ExecutionEngine/JITLink/x86_64.h
llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
llvm/lib/ExecutionEngine/JITLink/MachO_x86_64.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107967.366003.patch
Type: text/x-patch
Size: 16695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210812/1ef23f09/attachment.bin>
More information about the llvm-commits
mailing list