[PATCH] D107953: [Flang] test_symbols.py module file fix

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Males sense, thank you for working on this! I've made a couple of small suggestions.



================
Comment at: flang/test/Semantics/test_symbols.py:6-8
 Expects a source file passed as the first argument;
-Expects the Flang frontdriver with options as second argument."""
+Expects a temporary directory as the second argument;
+Expects the Flang frontend driver with options as third argument."""
----------------
I'm suggesting a small edit to make it clearer what the input arguments to this script are.


================
Comment at: flang/test/Semantics/test_symbols.py:20
 src = cm.set_source(sys.argv[1])
+tmp = cm.set_temp(sys.argv[2])
+cwd = os.getcwd()
----------------
I'm suggesting a bit more descriptive variable here. `tmp` could mean a temporary file, directory, socket etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107953/new/

https://reviews.llvm.org/D107953