[PATCH] D107262: [CodeGenPrepare] The instruction to be sunk should be inserted before its user in a block

Tiehu Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 00:25:46 PDT 2021


TiehuZhang added a comment.

Hi, @dmgreen, the previous implementation doesn't take the order of extends into account, so `Instruction does not dominate all uses` error will still appear in one of the testcases you mentioned. I have updated the patch to fix the failed case. Could you please check whether this modification is appropriate? Thanks very much.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107262/new/

https://reviews.llvm.org/D107262



More information about the llvm-commits mailing list