[PATCH] D107914: [PowerPC] Disable CTR Loop generate for fma with the PPC double double type.

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:462
+          // Thus, we need to disable CTR loop generation for this type and
+          // keep it as an call.
+          case Intrinsic::fmuladd:
----------------
Enable/disable CTR loop generation can not make sure the `Intrinsic::fmuladd` be kept as a call. Can we move these lines to line 500?


================
Comment at: llvm/test/CodeGen/PowerPC/disable-ctr-ppcf128.ll:149
+  %i = phi ppc_fp128 [ %i11, %bb6 ], [ 0xM00000000000000000000000000000000, %bb ]
+  %i7 = phi i64 [ %i12, %bb6 ], [ 0, %bb ]
+  %i8 = tail call ppc_fp128 @llvm.fmuladd.ppcf128(ppc_fp128 0xM00000000000000000000000000000000, ppc_fp128 0xM00000000000000000000000000000000, ppc_fp128 %i) #4
----------------
Can we narrow down the case a little bit? maybe one call is enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107914/new/

https://reviews.llvm.org/D107914