[PATCH] D107940: [WebAssembly] Disable offset folding for function addresses

[Heejin Ahn via Phabricator via llvm-commits]

aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/function-pointer-offset.ll:19
+  ; wasm does not support with function addresses with offsets. This folding
+  ; should be disabled.
+  switch i32 ptrtoint (void (i8*)* @ham to i32), label %bb4 [
----------------
sbc100 wrote:
> Seems odd not to have any checks here other than the successful compile.. but maybe just the fact that we don't see the fatal error is enough?  Perhaps mention that if folding did occur a fatal error would be generated in the backend?
Yeah this shouldn't crash. But added some `CHECK` lines too, and added a description that this shouldn't crash in MCInstLower.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107940/new/

https://reviews.llvm.org/D107940