[PATCH] D107929: [GlobalISel] Narrow binops feeding into G_AND with a mask

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4396-4400
+  EVT NarrowEVT = getApproximateEVTForLLT(NarrowTy, DL, Ctx);
+  EVT WideEVT = getApproximateEVTForLLT(WideTy, DL, Ctx);
+  if (!TLI.isTruncateFree(WideEVT, NarrowEVT) ||
+      !TLI.isZExtFree(NarrowEVT, WideEVT))
+    return false;
----------------
If we're going to rely on these TLI hooks, I would rather add LLT overloads and let the default implementation use the approximate function


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107929/new/

https://reviews.llvm.org/D107929