[PATCH] D107784: Fix SEH table addresses for Windows

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 11 14:51:25 PDT 2021


rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/WinException.h:43
+  /// True if we are generating exception handling on Windows for ARM (Thumb).
+  bool isThumb = false;
+
----------------
dpaoliello wrote:
> @rnk Would you prefer if I followed the existing casing here, or used the casing that clang-tidy suggests?
Let's stay consistent with what's here and ignore clang-tidy for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107784/new/

https://reviews.llvm.org/D107784



More information about the llvm-commits mailing list