[PATCH] D107872: [SimplifyLibCalls] propagate tail flag on FORTIFY calls

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 11 13:35:14 PDT 2021


efriedma added a comment.

On a sort-of-related note, should we avoid optimizing musttail and/or notail calls here?



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:3516
+    if (CI->isTailCall() && !SimplifiedCI->isTailCall())
+      SimplifiedCI->setTailCall();
+
----------------
This isn't the right call in some cases, I think.  For example, for memmove, this is the operand to the memmove, not the memmove itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107872/new/

https://reviews.llvm.org/D107872



More information about the llvm-commits mailing list