[PATCH] D107897: [FuncSpec] Don't specialize function which are easy to inline

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added a comment.

I think this patch raises the question whether the pass today is running at the right place in the pipeline with respect to the inliner. To me it seems that either the cost modeling should leverage the InlineCost heuristics (rather than arbitrary constants tuned on SPEC) or specialize post-inlining where such decision-making may no longer be necessary. This is particularly important with the presence of PGO information which significantly affects inlining decisions. It would be appreciated if we could spend some time studying the impact of timing of the pass before committing to this direction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107897/new/

https://reviews.llvm.org/D107897