[PATCH] D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass

[Rong Xu via Phabricator via llvm-commits]

xur added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1116-1118
+  if (EnableFSDiscriminator)
+    addPass(createMIRAddFSDiscriminatorsPass(
+        sampleprof::FSDiscriminatorPass::Pass1));
----------------
hoy wrote:
> wenlei wrote:
> > wmi wrote:
> > > How about adding a comment that the pass is intentionally placed before regalloc, in case some other passes are inserted in between in the future. 
> > name `FSDiscriminatorPass::Pass1` as something like `FSDiscriminatorPass::RegAlloc` might help too.
> Either way sounds good to me. Was wondering if Pass1, Pass2... should be named more specifically by the pass they are preceding. On a second thought, if they are moved around in the future, their name may need be changed too. 
Yes. I have the same concern if we change the names. Let's keep the Pass1 etc for now. Adding a comment definitely helps. Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104579/new/

https://reviews.llvm.org/D104579