[PATCH] D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 11 09:38:46 PDT 2021
- Previous message: [PATCH] D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding
- Next message: [llvm] 6f5edc3 - [RISCV] Fold (add (select lhs, rhs, cc, 0, y), x) -> (select lhs, rhs, cc, x, (add x, y))
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
hoy added a comment.
In D107838#2939694 <https://reviews.llvm.org/D107838#2939694>, @stella.stamenova wrote:
> This change introduced a race condition in the build and we saw it fail in our private buildbots on both Ubuntu and Windows because of a dependency on `Attributes.inc` (the target `intrinsics_gen`) which had previously been covered by the `ProfileData` library. I haven't confirmed whether https://reviews.llvm.org/rG68d6c3e4486c6743dfa419ec0d919d8e97fdad05 removed that dependency by removing the header from `ProfileData`, though it likely does, so I wanted to leave a note here for anyone else who runs into this - or if it recurs.
Thanks for letting me know. As you pointed out, https://reviews.llvm.org/rG68d6c3e4486c6743dfa419ec0d919d8e97fdad05 should fix the issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107838/new/
https://reviews.llvm.org/D107838
- Previous message: [PATCH] D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding
- Next message: [llvm] 6f5edc3 - [RISCV] Fold (add (select lhs, rhs, cc, 0, y), x) -> (select lhs, rhs, cc, x, (add x, y))
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the llvm-commits
mailing list