[PATCH] D105871: Followup to D99355: implementation of sdag support for vp load/store/gather/scatter.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 11 03:55:12 PDT 2021
frasercrmck added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7385
+ MachineMemOperand *MMO = DAG.getMachineFunction().getMachineMemOperand(
+ MachinePointerInfo(PtrOperand), MachineMemOperand::MOLoad,
+ VT.getStoreSize().getKnownMinSize(), *Alignment, AAInfo);
----------------
I don't think you can use `PtrOperand` to initialize the `MachineMemOperand` for `VP_GATHER` because it's not a pointer - it's a vector of pointers.
The regular `llvm.masked.gather` intrinsic creates a `MachinePointerInfo` using only the address space.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7427
+ MachineMemOperand *MMO = DAG.getMachineFunction().getMachineMemOperand(
+ MachinePointerInfo(PtrOperand), MachineMemOperand::MOStore,
+ VT.getStoreSize().getKnownMinSize(), *Alignment, AAInfo);
----------------
Same concern about `MachinePointerInfo` as with `VP_GATHER`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105871/new/
https://reviews.llvm.org/D105871
More information about the llvm-commits
mailing list