[PATCH] D107474: [AMDGPU] Better legalization of ctlz/cttz
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 11 03:18:38 PDT 2021
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2542
? AMDGPU::G_AMDGPU_FFBH_U32
- : AMDGPU::G_AMDGPU_FFBL_B32;
- unsigned Idx = Opc == AMDGPU::G_CTLZ_ZERO_UNDEF;
+ : Opc == AMDGPU::G_CTLZ_ZERO_UNDEF
+ ? AMDGPU::G_AMDGPU_FFBL_B32
----------------
@foad Coverity is complaining that you've repeated the 'Opc == AMDGPU::G_CTLZ_ZERO_UNDEF' check (which is dead code) - should the second one be 'Opc == AMDGPU::G_CTTZ_ZERO_UNDEF' ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107474/new/
https://reviews.llvm.org/D107474
More information about the llvm-commits
mailing list