[PATCH] D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option.

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 11 00:25:19 PDT 2021


Esme added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:110
+  char Padding[4];
+  support::big32_t OffsetToRelEnt;
+};
----------------
Esme wrote:
> shchenz wrote:
> > 32 bit loader section should have no `l_rldoff` field?
> According to the spec, there is no `l_symoff(OffsetToSymTbl)` in 32-bit Loader section, but there is `l_rldoff(OffsetToRelEnt)`.
Ok, sorry, it seems the spec has some inconsistency on LoaderSectionHeader32, and you're right that 32-bit has no `l_rldoff`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106643/new/

https://reviews.llvm.org/D106643



More information about the llvm-commits mailing list