[PATCH] D107817: [RISCV][test] Add new tests for mul optimization in the zba extension with SH*ADD

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rv64zba.ll:7
 ; RUN: llc -mtriple=riscv64 -mattr=+m,+experimental-zba -verify-machineinstrs < %s \
 ; RUN:   | FileCheck %s -check-prefix=RV64IBA
 
----------------
craig.topper wrote:
> benshi001 wrote:
> > jrtc27 wrote:
> > > Ugh this is confusing, should be RV64IBZBA, not RV64IBA (which would mean integer, bitmanip and atomics, albeit in a non-canonical order, which makes no sense for this test)
> > Sure. I will correct that before 'git push'
> Why RV64IBZBA and not RV64IZBA? Should the M be mentioned for the +m?
> 
> All of the B extension tests are like this and have been since they were created.
Please don't. All the tests should be corrected at once and not part of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107817/new/

https://reviews.llvm.org/D107817