[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15962
 
   if (Depth > 0) {
+    SDValue FrameAddr =
----------------
Please add a comment:
```
// The link register (return address) is saved in the caller's frame
// not the callee's stack frame. So we must get the caller's frame
// address and load the return address at the LR offset from there.
```


================
Comment at: llvm/test/CodeGen/PowerPC/2010-05-03-retaddr1.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu  | FileCheck %s
----------------
It is very hard to see what the actual differences are when you have changed the codegen as well as how the checks are produced in the same review. Could you please use the script to produce the checks and pre-commit that? Then this will show just the differences due to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107646/new/

https://reviews.llvm.org/D107646