[PATCH] D107173: [CSSPGO] Introduce MD5-based context-sensitive profile

Tue Aug 10 17:31:56 PDT 2021

wenlei added a comment.

In D107173#2938207 <https://reviews.llvm.org/D107173#2938207>, @hoy wrote:

> In D107173#2929418 <https://reviews.llvm.org/D107173#2929418>, @wmi wrote:
>
>>>> I tried the idea of using vector<Callsite> (Callsite is a struct containing function name and LineLocation) in SampleContext and changed the ProfileMap to be map<SampleContext, FunctionSamples> in the last two days. I believed the idea should work but I found the required change was much larger than I thought since ProfileMap has been used in many interfaces. I am worried that for the moment I cannot devote enough time to finish the whole change, so now I tend to use Hongtao's md5 patch and leave the further improvement to the future since the current patch has already significantly improved the build process and unblocked our experiment. We can always come back to revisit it. What is your opinion?
>>>
>>> Thanks for the heads-up, Wei. Sounds good to stick with this patch for now, if you need more time to complete your idea which I think will get us a bigger win and be more aligned with the non-CS implementation. Will you continue working on that?
>>
>> Probably I cannot work on it this quarter, so if you like to work on it, free to take D107299 <https://reviews.llvm.org/D107299> and I will be happy to review it. If you think getting this patch in as a short term solution is preferred, I can start reviewing it.
>
> Thanks for the heads-up @wmi . I will take your current change and work from there.

Sounds good. split names could be a better solution. Btw, I suggest we separate out the context tracker change to use md5 - it should be orthogonal.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107173/new/

https://reviews.llvm.org/D107173