[PATCH] D107653: [llvm-objcopy][ELF] Avoid reordering section headers

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 16:38:35 PDT 2021


MaskRay added a comment.

Looks good.



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:2312
+  }
+  llvm::stable_sort(Sections,
+                    [](const SectionBase *Lhs, const SectionBase *Rhs) {
----------------
No test fails if I comment out this stable_sort .

You may need a --only-keep-debug test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107653/new/

https://reviews.llvm.org/D107653



More information about the llvm-commits mailing list