[PATCH] D107630: [docs][GlobalISel]Adding info for G_JUMP_TABLE generic opcode

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 14:18:13 PDT 2021


paquette added a comment.

Added some stylistic nits.



================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:801
 
-.. caution::
+This generic jump table opcode generates a pointer to the address of the jump 
+table specified by the source operand, which is a jump table index. (A jump 
----------------
Maybe a little more concise?


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:802
+This generic jump table opcode generates a pointer to the address of the jump 
+table specified by the source operand, which is a jump table index. (A jump 
+table is an array of addresses the CPU should jump to based on certain 
----------------
- Maybe split this sentence up?
- I don't think parens are necessary here.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:805
+conditions.)
+It can be used in conjunction with G_BRJT opcode to support jump table codegen 
+with GlobalISel.
----------------
- Remind the reader about what "it" is
- Noun-ify G_BRJT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107630/new/

https://reviews.llvm.org/D107630



More information about the llvm-commits mailing list