[PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on most platforms

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D107799#2938070 <https://reviews.llvm.org/D107799#2938070>, @phosek wrote:

>> However, some `*.cmake` files have `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE`.
>> And I do not know what the Windows case is. @mstorsjo
>
> We use `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` on Windows (in MSVC) with our toolchain without any issues. That toolchain is also used by several projects like Fluter, Dart and Pigweed and they haven't reported any issues.

FWIW I build my toolchains by building compiler-rt/libcxx/libcxxabi/libunwind separately, so the default set here won't affect me directly (but others may be building it for mingw this way so it matters if it works). For compiler-rt builtins libraries I would presume it works fine (but I'll test), but I see that it does affect where the output from libunwind/libc++ end up as well, and I'm not quite as confident about whether those are picked up as they should in the mingw setups. (There, most things are already sorted by target architecture in the form of `<compiler_binary>/../<target_triple>/{include,lib}`, and e.g. the runtimes are built with `<compiler_binary>/../<target_triple>` as `CMAKE_INSTALL_PREFIX`. But I'll try it out for the different libraries and see how it behaves.

I'd prefer if you can hold off enabling it for Windows until I've confirmed that it works in mingw setups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799