[PATCH] D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass

[Rong Xu via llvm-commits]

On Tue, Aug 10, 2021 at 11:54 AM Wei Mi via Phabricator <
reviews at reviews.llvm.org> wrote:

> wmi added a comment.
>
> > This extra pass turns to be positive in performance -- I'm seeing
> additional 0.6% - 0.8% improvement.
>
> That is a good improvement. I guess the improvement is because regalloc is
> profile sensitive and it is benefited from preciser fs profile information
> after you insert another pass of profile loading before regalloc?
>
Yes. I guess so.
That's actually a bit surprising to me as I did not think RA was so
sensitive to profile quality.
But the improvement is real as I can constantly reproduce in every run.

>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104579/new/
>
> https://reviews.llvm.org/D104579
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210810/07607fc9/attachment.html>