[PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 12:18:07 PDT 2021
MaskRay added subscribers: daltenty, mstorsjo, ro, joerg.
MaskRay added a comment.
In D107799#2937768 <https://reviews.llvm.org/D107799#2937768>, @phosek wrote:
> @MaskRay is there a reason why we're restricting this only to Linux? This layout is supported on all platforms except for Darwin which already has special handling so setting `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` everywhere is going to work.
I'd love to enable it for other OSes as well.
However, some `*.cmake` files have `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE`.
And I do not know what the Windows case is. @mstorsjo
Perhaps let all ELF OSes enable this by default?
if(CMAKE_SYSTEM_NAME MATCHES "Darwin") # I can add more OSes here
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default OFF)
else()
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
endif()
?
(@joerg NetBSD; @ro SunOS; @daltenty AIX)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107799/new/
https://reviews.llvm.org/D107799
More information about the llvm-commits
mailing list