[PATCH] D107853: [NFC][AVR] Remove unused isMachineVerifierClean()

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 11:55:29 PDT 2021


xgupta created this revision.
xgupta added reviewers: fhahn, RKSimon.
Herald added subscribers: Jim, hiraditya, dylanmckay.
xgupta requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

r304320 enabled the machine verifier by default with
EXPENSIVE_CHECKS. Mistakenly AVR was in the one of the targets 
excluded from this by overriding TargetMachine::isMachineVerifierClean() to 
return false in D33696 <https://reviews.llvm.org/D33696>.

      

Removing the override as the target passes all lit tests without machine 
verifier failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107853

Files:
  llvm/lib/Target/AVR/AVRTargetMachine.h


Index: llvm/lib/Target/AVR/AVRTargetMachine.h
===================================================================
--- llvm/lib/Target/AVR/AVRTargetMachine.h
+++ llvm/lib/Target/AVR/AVRTargetMachine.h
@@ -42,10 +42,6 @@
 
   TargetPassConfig *createPassConfig(PassManagerBase &PM) override;
 
-  bool isMachineVerifierClean() const override {
-    return false;
-  }
-
 private:
   std::unique_ptr<TargetLoweringObjectFile> TLOF;
   AVRSubtarget SubTarget;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107853.365571.patch
Type: text/x-patch
Size: 456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210810/7c839eee/attachment.bin>


More information about the llvm-commits mailing list