[PATCH] D107845: [DAG] Reword comment for EnforceNodeIdInvariant and InvalidateNodeId. NFC.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 10:41:16 PDT 2021


niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

LGTM modulo minor typo that was missed from before.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1060
+// our legality checks would be incorrect. To avoid this we mark all unselected
 // sucessor nodes, i.e. id != -1 as invalid for pruning by bit-negating (x =>
 // (-(x+1))) the ids and modify our pruning check to ignore negative Ids of M.
----------------
While we're at it, "successor"*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107845/new/

https://reviews.llvm.org/D107845



More information about the llvm-commits mailing list