[PATCH] D107350: Add a trait to Sequence to iterate enums
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 08:55:02 PDT 2021
kuhar added a comment.
In D107350#2937092 <https://reviews.llvm.org/D107350#2937092>, @gchatelet wrote:
> Ah I see, then maybe the name should raise a visual warning, How about `forge_iterable_enum`?
>
> SG for the unused attribute.
>
> I'll update this patch based on your implementation and we can iterate from here.
SGTM.
I talked with @gchatelet offline and since he will be on vacation soon, I'll take over the implementation and continue in the other patch (https://reviews.llvm.org/D107378) from here.
One concern brought up offline was that we should avoid the duplication the integer vs enum logic between seq and seq_inclusive (the two notions are no more orthogonal). We should try to push the enum logic to iota_range instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107350/new/
https://reviews.llvm.org/D107350
More information about the llvm-commits
mailing list