[PATCH] D107830: [AIX] Don't crash on unimplemented lowerRelativeReference
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 08:23:31 PDT 2021
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
Yes, it looks like the default implementation in the base class just returns `nullptr` and some other implementations reach points where they return `nullptr`. LGTM; thanks.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2459
const TargetMachine &TM) const {
- report_fatal_error("XCOFF not yet implemented.");
+ /* Not implemented yet, but don't crash, return nullptr*/
+ return nullptr;
----------------
Minor nit: formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107830/new/
https://reviews.llvm.org/D107830
More information about the llvm-commits
mailing list