[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 08:06:41 PDT 2021


lei added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr9-warning.c:4
+// RUN:   -verify %s
+
+extern unsigned long long ull;
----------------
NeHuang wrote:
> can we also add the run lines for 64 bit LE Linux, 64 bit AIX and 32 bit AIX?  Will also need `#ifdef __PPC64__` for the test case. 
AFAIK there is no difference between LE and BE for sema checking and it'll be overkill to add the `ifdef` since the only run line in here is for 64bit compilation.  I think that can be added later if there are needs for 32bit testcases later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107002/new/

https://reviews.llvm.org/D107002



More information about the llvm-commits mailing list