[PATCH] D107829: SplitKit: Don't further split subrange mask in buildCopy

Tue Aug 10 08:04:28 PDT 2021

ruiling added a comment.

In D107829#2937029 <https://reviews.llvm.org/D107829#2937029>, @ruiling wrote:

> In D107829#2937013 <https://reviews.llvm.org/D107829#2937013>, @arsenm wrote:
>
>> I'm currently working on yet another patch for this which also apparently works. With this patch, can you delete the subrange handling in extendPHIKillRanges?
>
> Do you mean completely removing the code in the loop `for (LiveInterval::SubRange &PS : ParentLI.subranges())` in `SplitEditor::extendPHIKillRanges()`? I am not sure about this, I may need some further investigation.

I am not sure why do you think of removing that piece of code? That is used to correctly update the subranges. Did I misunderstand your point?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107829/new/

https://reviews.llvm.org/D107829