[PATCH] D107747: [ELF] Don't emit SHF_GNU_RETAIN on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 05:31:35 PDT 2021


ro added a comment.

In D107747#2934856 <https://reviews.llvm.org/D107747#2934856>, @MaskRay wrote:

> 



> Instrumentation based PGO has names variables referenced by `llvm.used`. Without a `SHF_GNU_RETAIN` counterpart indirect call profiling cannot work.

But isn't this the same with pre-binutils 2.36 GNU `ld` and still there are no precautions about this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107747/new/

https://reviews.llvm.org/D107747



More information about the llvm-commits mailing list