[PATCH] D107016: [DebugInfo][LoopStrengthReduction] Ensure restoration of cached DIExpression when using SCEV-based salvaging

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D107016#2925136 <https://reviews.llvm.org/D107016#2925136>, @chrisjackson wrote:

> I believe this is already covered somewhat by /test/Transforms/LoopStrengthReduce/dbg-preserve-2.ll.

Just to confirm, was `dbg-preserve-2.ll` failing before this patch?



================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6190
+      // LSR may have updated the expression, so restore to the expression
+      // that corresponds to te cached SCEV.
+      DVIRec.DVI->setExpression(DVIRec.Expr);
----------------
Orlando wrote:
> 
Nit, typo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107016/new/

https://reviews.llvm.org/D107016