[PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment
xiongji90 via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 10 01:54:46 PDT 2021
xiongji90 added inline comments.
================
Comment at: libunwind/src/UnwindLevel1.c:173
+ unsigned int framesWalked = 0;
// Walk each frame until we reach where search phase said to stop.
----------------
MaskRay wrote:
>
Fixed.
Thanks very much.
================
Comment at: libunwind/src/UnwindLevel1.c:223
+ framesWalked++;
// If there is a personality routine, tell it we are unwinding.
----------------
MaskRay wrote:
> https://llvm.org/docs/CodingStandards.html#prefer-preincrement
Fixed.
Thanks very much.
================
Comment at: libunwind/src/UnwindLevel1.c:287
+ unsigned int framesWalked = 0;
// Walk each frame until we reach where search phase said to stop
----------------
MaskRay wrote:
>
Fixed.
Thanks very much.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105968/new/
https://reviews.llvm.org/D105968
More information about the llvm-commits
mailing list