[PATCH] D106653: [LoopVectorize][AArch64] Enable ordered reductions by default for AArch64

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 10 01:46:53 PDT 2021


david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-strict-fadd.ll:5
 ; RUN: opt < %s -loop-vectorize -scalable-vectorization=on -mtriple aarch64-unknown-linux-gnu -mattr=+sve -force-ordered-reductions=true  -hints-allow-reordering=true  -S 2>%t | FileCheck %s --check-prefix=CHECK-UNORDERED
+; RUN: opt < %s -loop-vectorize -scalable-vectorization=on -mtriple aarch64-unknown-linux-gnu -mattr=+sve -hints-allow-reordering=false  -S 2>%t | FileCheck %s --check-prefix=CHECK-ORDERED
 
----------------
spatel wrote:
> Drive-by comment (checking my understanding) - we could add this RUN line with `--check-prefix=CHECK-NOT-VECTORIZED` as a preliminary commit and then update only the prefix to show the change in behavior with this patch?
That sounds like a good idea! I'll commit a one line patch to do this and then rebase.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106653/new/

https://reviews.llvm.org/D106653



More information about the llvm-commits mailing list