[PATCH] D107219: [LICM] Support sinking in LNICM

[toshiki maekawa via Phabricator via llvm-commits]

uint256_t added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:155
+                SinkAndHoistLICMFlags &, OptimizationRemarkEmitter *,
+                Loop * = nullptr);
+
----------------
bmahjour wrote:
> Please name the parameters of this function and add a comment about what each parameter means. Someone reading this declaration and its comments will see two `Loop *` being passed and cannot figure out what they are without going through its implementation.
Okay, I'll name the parameter `Loop * = nullptr` and add a comment to explain what two `Loop *` are. I don't think I need to name all parameters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107219/new/

https://reviews.llvm.org/D107219