[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 9 16:46:00 PDT 2021


MaskRay created this revision.
MaskRay added reviewers: anemet, hoy, tejohnson.
Herald added subscribers: ormris, wenlei, steven_wu, hiraditya.
MaskRay requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Clang diagnostics refer to identifier names in quotes.
This patch makes inline remarks conform to the convention.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107791

Files:
  clang/test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
  clang/test/Frontend/optimization-remark-line-directive.c
  clang/test/Frontend/optimization-remark-new-pm.c
  clang/test/Frontend/optimization-remark-with-hotness-new-pm.c
  clang/test/Frontend/optimization-remark-with-hotness.c
  clang/test/Frontend/optimization-remark.c
  clang/test/Frontend/remarks-hotness.cpp
  llvm/lib/Analysis/InlineAdvisor.cpp
  llvm/test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll
  llvm/test/LTO/X86/diagnostic-handler-remarks.ll
  llvm/test/Other/optimization-remarks-auto.ll
  llvm/test/Other/optimization-remarks-inline.ll
  llvm/test/ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll
  llvm/test/ThinLTO/X86/diagnostic-handler-remarks.ll
  llvm/test/Transforms/Inline/ARM/inline-fp.ll
  llvm/test/Transforms/Inline/cgscc-inline-replay.ll
  llvm/test/Transforms/Inline/inline_noprofile.ll
  llvm/test/Transforms/Inline/inline_nossp.ll
  llvm/test/Transforms/Inline/optimization-remarks-hotness-threshold.ll
  llvm/test/Transforms/Inline/optimization-remarks-passed-yaml.ll
  llvm/test/Transforms/Inline/optimization-remarks-with-hotness.ll
  llvm/test/Transforms/Inline/optimization-remarks.ll
  llvm/test/Transforms/SampleProfile/csspgo-inline-icall.ll
  llvm/test/Transforms/SampleProfile/csspgo-inline.ll
  llvm/test/Transforms/SampleProfile/inline-replay.ll
  llvm/test/Transforms/SampleProfile/remarks-hotness.ll
  llvm/test/Transforms/SampleProfile/remarks.ll
  llvm/test/tools/gold/X86/remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107791.365315.patch
Type: text/x-patch
Size: 35504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210809/57dcec97/attachment.bin>


More information about the llvm-commits mailing list