[PATCH] D107784: Fix SEH and IP2State table addresses for Windows

Daniel Paoliello via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 9 14:57:14 PDT 2021


dpaoliello created this revision.
Herald added subscribers: pengfei, hiraditya.
dpaoliello requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Issue Details:
The addresses for SEH and IP2State tables for Windows are incorrect as 1 was unconditionally being added to all addresses. +1 is required for the SEH end address (as it is exclusive), but the SEH start addresses and IP2State addresses are both inclusive and so should be used as-is.

Fix Details:
Change the `getLabel` helper to not add 1. Add 1 for the SEH end address after using `getLabel` (with a comment explaining why).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107784

Files:
  llvm/lib/CodeGen/AsmPrinter/WinException.cpp
  llvm/test/CodeGen/WinEH/wineh-noret-cleanup.ll
  llvm/test/CodeGen/X86/catchret-empty-fallthrough.ll
  llvm/test/CodeGen/X86/seh-catchpad.ll
  llvm/test/CodeGen/X86/seh-except-finally.ll
  llvm/test/CodeGen/X86/seh-finally.ll
  llvm/test/CodeGen/X86/seh-safe-div.ll
  llvm/test/CodeGen/X86/seh-unwind-inline-asm-codegen.ll
  llvm/test/CodeGen/X86/win-catchpad-nested-cxx.ll
  llvm/test/CodeGen/X86/win-catchpad.ll
  llvm/test/CodeGen/X86/win-cleanuppad.ll
  llvm/test/CodeGen/X86/win32-eh-states.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107784.365292.patch
Type: text/x-patch
Size: 12841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210809/de77fe20/attachment.bin>


More information about the llvm-commits mailing list