[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

Mon Aug 9 14:23:13 PDT 2021

amyk added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/retaddr_multi_levels.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc64le-unknown-linux -mcpu=pwr8 | FileCheck %s -check-prefix=CHECK-64B-LE
+; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc64-unknown-linux -mcpu=pwr7 | FileCheck %s -check-prefix=CHECK-64B-BE
----------------
nit: The RUN lines look a bit too long in this test.

================
Comment at: llvm/test/CodeGen/PowerPC/retaddr_multi_levels.ll:21
+;
+; CHECK-64B-BE-LABEL: test0:
+; CHECK-64B-BE:       # %bb.0: # %entry
----------------
At a glance, it looks like `CHECK-64B-BE` and `CHECK-64B-AIX` looks like they're the same CHECKs.
Do you think it's a good idea to combine them into a single check/use check-prefixes? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107646/new/

https://reviews.llvm.org/D107646