[PATCH] D106872: [InstCombine] Remove nnan requirement for transformation to fabs from select

Krishna Kariya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 9 10:29:48 PDT 2021


Krishnakariya added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/fabs.ll:252-253
 
 ; Negative test for the fabs folds below: we require nnan, so
 ; we won't always clear the sign bit of a NaN value.
 
----------------
nick wrote:
> The comment had not been updated and is wrong now.
Ohh, thanks for finding it out! I am removing this comment.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106872/new/

https://reviews.llvm.org/D106872



More information about the llvm-commits mailing list