[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:599
 * SPIR
+* X86
 
----------------
Might be worth mentioning that it requires AVX512FP16 here


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2817
       Current = SSE;
+    } else if (k == BuiltinType::Float16) {
+      Current = SSE;
----------------
Merge with the previous if?


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2948
         Lo = Hi = Integer;
+    } else if (ET->isFloat16Type()) {
+      Current = SSE;
----------------
Merge with the FloatTy if?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105263/new/

https://reviews.llvm.org/D105263