[PATCH] D105462: [X86] Add CRC32 feature.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/crc32intrin.h:13
+
+#define __DEFAULT_FN_ATTRS \
+  __attribute__((__always_inline__, __nodebug__, __target__("crc32")))
----------------
Better to follow Lint's suggestions.


================
Comment at: clang/lib/Headers/crc32intrin.h:31
+static __inline__ unsigned int __DEFAULT_FN_ATTRS
+_mm_crc32_u8(unsigned int __C, unsigned char __D)
+{
----------------
ditto.


================
Comment at: clang/lib/Headers/immintrin.h:518
+    defined(__CRC32__)
+#include <crc32intrin.h>
+#endif
----------------
Should it be better to move together with "include <smmintrin.h>"?


================
Comment at: clang/lib/Headers/smmintrin.h:2347
 
+#include <crc32intrin.h>
+
----------------
Should it be added to gprintrin.h too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105462/new/

https://reviews.llvm.org/D105462