[PATCH] D45962: [MC] Use local MCSubtargetInfo in writeNops

Mon Aug 9 04:01:19 PDT 2021

peter.smith added a comment.

In D45962#2931626 <https://reviews.llvm.org/D45962#2931626>, @peter.smith wrote:

> In D45962#2919645 <https://reviews.llvm.org/D45962#2919645>, @peter.smith wrote:
>
>> Thanks for the review. I've just got back from vacation and I'm a bit behind. Will rebase this and D45961 <https://reviews.llvm.org/D45961> hopefully by the end of this week. I'll post it here and will give a heads up if there are any meaningful changes.
>
> Will be early next week. I've rebased D45962 <https://reviews.llvm.org/D45962> which this depends on.

I've just had a quick go at rebasing and there is a bit more work than I bargained for. The X86 backend has introduced a couple more MCFragments that will need adapting

- MCBoundaryAlignFragment
- MCNopsFragment

I think I can pass STI through to these wihtout any ill effect but I'd like to submit these as individual  patches for review as I don't know X86 well.

The X86 backend has used its per-target STI for some other things as well, so I won't be able to remove it in this patch.

ETA for this will be Friday afternoon (doing this in spare time).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45962/new/

https://reviews.llvm.org/D45962