[PATCH] D106250: [NFC][LoopUtils] Use RewritePhi::ExpansionPoint for Inst to be replaced.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 9 02:02:28 PDT 2021


HsiangKai added a comment.

In D106250#2933594 <https://reviews.llvm.org/D106250#2933594>, @mkazantsev wrote:

> Any tests showing the difference?

There should be no difference for the modification.
In LoopUtils.cpp:1337 <https://github.com/llvm/llvm-project/blob/2bb4ebb19e8893634fd2491d55c127b8ba58e637/llvm/lib/Transforms/Utils/LoopUtils.cpp#L1337>, the structure `RewritePhi` is initialized. `PN->getIncomingValue(Phi.Ith)` should be equal to `Phi.ExpansionPoint`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106250/new/

https://reviews.llvm.org/D106250



More information about the llvm-commits mailing list