[PATCH] D106408: Allow rematerialization of virtual reg uses

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/ldr-str-imm12.ll:52
+; CHECK: strd r{{[0-9]+}}, {{(r[0-9]+)|(lr)}}, [sp
+; CHECK: strd r{{[0-9]+}}, {{(r[0-9]+)|(lr)}}, [sp
   store volatile %union.rec* null, %union.rec** @zz_hold, align 4
----------------
rampitec wrote:
> dmgreen wrote:
> > On second thoughts, can you just run the update_llc_test_checks on this file?
> > 
> > The strd is just two adjacent str glommed together, so this is checking for more stores than it was before. But there appear to be extra stores in the original, including stm.  From the comment at the top of the file it is not very clear what this is trying to test now. Just updating the test checks so that we see the whole function sounds like the best idea.
> Maybe switch to generated checks, precommit and update the test in the review? That way you will better see what has changed. That is more or less what I've been doing looking at it.
> 
> JFYI I am not good in thumb isa, so I am guessing what has changed.
Yeah, I had taken a look to see how it's changing. It looks fine to me.

Thanks for updating the test checks. It looks like a more useful test now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106408/new/

https://reviews.llvm.org/D106408