[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 16:01:09 PDT 2021


rampitec added a comment.

In D106891#2921108 <https://reviews.llvm.org/D106891#2921108>, @gandhi21299 wrote:

> How can I construct an ORE to start off with? I don't think its appropriate to construct it in `shouldExpandAtomicRMWInsts(RMW)`

You have already constructed it. You can just pass it to `shouldExpandAtomicRMWInsts`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891



More information about the llvm-commits mailing list